Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logging #9288

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Update Logging #9288

merged 2 commits into from
Oct 31, 2024

Conversation

chidozieononiwu
Copy link
Member

  • Update logging command

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner October 30, 2024 21:07
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

}

function LogDebug
function LogSuccess {
$esc = [char]27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if these show up in DevOps or github logs? I suspect these might only interpreted locally in a console window.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it works on DevOps and GitHub Actions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it look like there? Does it display those chars?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok does that work in DevOps logs as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

chidozieononiwu added a commit to Azure/azure-sdk-for-js that referenced this pull request Oct 31, 2024
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9288 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
@chidozieononiwu chidozieononiwu merged commit 93ef611 into Azure:main Oct 31, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants