Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Test Proxy logging error output into a different log file #9460

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

alzimmermsft
Copy link
Member

Updates the Test Proxy scripts to support outputting error logs into test-proxy-error.log. This should also standardize behaviors between Windows and Linux/macOs where Start-Process doesn't appear to include error output when -RedirectStandardError isn't supplied whereas &> for nohup will redirect all output to the given location.

With this there will be two files that need to be managed for Test Proxy, so publish-proxy-logs.yml is updated appropriately to grab test-proxy-error.log as well.

@alzimmermsft alzimmermsft requested a review from a team as a code owner December 4, 2024 14:39
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Before we merge this across the repos I/we gotta double check to ensure that we don't have conditional yaml in each pipeline that expects the original output of a single log file.

I don't protest the intent at all.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Dec 6, 2024
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9460 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: alzimmermsft <48699787+alzimmermsft@users.noreply.github.com>
@benbp benbp enabled auto-merge (squash) December 6, 2024 21:58
@benbp benbp merged commit 5578cb0 into Azure:main Dec 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants