[Python APIView] install optional dependencies on ImportError #9615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
reviewed
Jan 10, 2025
packages/python-packages/apiview-stub-generator/apistub/_stub_generator.py
Show resolved
Hide resolved
scbedd
reviewed
Jan 10, 2025
packages/python-packages/apiview-stub-generator/apistub/_stub_generator.py
Show resolved
Hide resolved
scbedd
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
I think it definitely seems reasonable based on our convo. Any thoughts from @tjprescott
tjprescott
reviewed
Jan 10, 2025
tjprescott
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
I'll defer to @praveenkuttapan and @scbedd on the best way to test this on CI to make sure it behaves, but the logic makes sense to me.
praveenkuttappan
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses: #9612
Fixes the issue, but may be a temporary solution depending on further discussion.
Local testing passed. Need to test against existing APIViews in the CI and azure-quantum.