This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Fix panic when specifying a nil session ID #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate the session ID selected by the broker when a nil session ID is specified. This requires an updated go-amqp to work. Removed validation of EnqueuedSequenceNumber as it's not guaranteed to be returned.
richardpark-msft
approved these changes
Jun 23, 2021
| const code = uint64(0x00000137000000C) | ||
|
|
||
| if !r.useSessions { | ||
| return nil, false | ||
| } | ||
|
|
||
| if r.sessionID == nil { | ||
| return amqp.LinkSourceFilter(name, code, nil), true | ||
| return amqp.LinkSourceFilter(sessionFilterName, code, nil), true |
There was a problem hiding this comment.
Looks like you don't need the 'if' here at all (ie, r.SessionID can just be passed unconditionally)
There was a problem hiding this comment.
This is one of the cases of "when nil isn't nil" in Go, and comes into play with interface{}. When passing nil, the type of the value interface{} param will be nil. When passing r.sessionID, the type will be *string. So while they both could in fact be nil, their underlying types are different. This is important to the marshal function in go-amqp which differentiates between underlying types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate the session ID selected by the broker when a nil session ID is
specified. This requires an updated go-amqp to work.
Removed validation of EnqueuedSequenceNumber as it's not guaranteed to
be returned.