-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the webhooks port to 9443 #1249
Conversation
ipTags: | ||
additionalProperties: | ||
type: string | ||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New properties on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ipTags
was added in #1246 - it's a map[string]string
so I think this is right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This enables running the operator in clusters that don't allow pods to bind ports below 1024 (like OpenShift with SCC on).
f6a9762
Closes #1177
What this PR does / why we need it:
It changes the webhook port on which the operator gets validation requests from 443 to 9443. This means that it doesn't need root privileges, which in turn means the pod can run in more restrictive environments like SCC on OpenShift.
Special notes for your reviewer:
Split out the nasty helm chart churn into a separate PR #1250.
How does this PR make you feel:
Delighted!
If applicable: