Change the webhooks port to 9443 #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbageclunk
requested review from
davefellows,
frodopwns,
jananivMS,
matthchr,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
theunrepentantgeek
previously approved these changes
Aug 5, 2020
| ipTags: | ||
| additionalProperties: | ||
| type: string | ||
| type: object |
There was a problem hiding this comment.
New properties on purpose?
There was a problem hiding this comment.
ipTags was added in #1246 - it's a map[string]string so I think this is right.
2 tasks
This enables running the operator in clusters that don't allow pods to bind ports below 1024 (like OpenShift with SCC on).
babbageclunk
dismissed stale reviews from matthchr and theunrepentantgeek
via
f6a9762
davefellows
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1177
What this PR does / why we need it:
It changes the webhook port on which the operator gets validation requests from 443 to 9443. This means that it doesn't need root privileges, which in turn means the pod can run in more restrictive environments like SCC on OpenShift.
Special notes for your reviewer:
Split out the nasty helm chart churn into a separate PR #1250.
How does this PR make you feel:
Delighted!
If applicable: