Don't CommitUpdate twice in a single reconcile loop #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
Porges and
theunrepentantgeek
as code owners
matthchr
commented
Aug 3, 2021
matthchr
commented
Aug 3, 2021
Porges
reviewed
Aug 4, 2021
Porges
approved these changes
Aug 4, 2021
matthchr
force-pushed
the
feature/fix-nondeterminism
branch
from
cf769c9
to
3518548
Compare
Multiple updates in a single loop means that there are multiple changes with new resourceVersions floating around. This then leads to races where you might end up reconciling on the resource from after update1 when you really want the change from after update2. Since the two-updates was just an optimization, removed it.
matthchr
force-pushed
the
feature/fix-nondeterminism
branch
from
3518548
to
2abefce
Compare
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
- Coverage 68.37% 68.34% -0.03%
==========================================
Files 214 214
Lines 15353 15342 -11
==========================================
- Hits 10498 10486 -12
- Misses 4090 4093 +3
+ Partials 765 763 -2
Continue to review full report at Codecov.
|
theunrepentantgeek
approved these changes
Aug 4, 2021
theunrepentantgeek
pushed a commit
that referenced
this pull request
Aug 6, 2021
Multiple updates in a single loop means that there are multiple changes with new resourceVersions floating around. This then leads to races where you might end up reconciling on the resource from after update1 when you really want the change from after update2. Since the two-updates was just an optimization, removed it.
theunrepentantgeek
pushed a commit
that referenced
this pull request
Aug 11, 2021
Multiple updates in a single loop means that there are multiple changes with new resourceVersions floating around. This then leads to races where you might end up reconciling on the resource from after update1 when you really want the change from after update2. Since the two-updates was just an optimization, removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple updates in a single loop means that there are multiple changes with new resourceVersions floating around. This then leads to races where you might end up reconciling on the resource from after update1 when you really want the change from after update2.
Since the two-updates was just an optimization, removed it.