-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't CommitUpdate twice in a single reconcile loop #1684
Conversation
cf769c9
to
3518548
Compare
Multiple updates in a single loop means that there are multiple changes with new resourceVersions floating around. This then leads to races where you might end up reconciling on the resource from after update1 when you really want the change from after update2. Since the two-updates was just an optimization, removed it.
3518548
to
2abefce
Compare
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
- Coverage 68.37% 68.34% -0.03%
==========================================
Files 214 214
Lines 15353 15342 -11
==========================================
- Hits 10498 10486 -12
- Misses 4090 4093 +3
+ Partials 765 763 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple updates in a single loop means that there are multiple changes with new resourceVersions floating around. This then leads to races where you might end up reconciling on the resource from after update1 when you really want the change from after update2. Since the two-updates was just an optimization, removed it.
Multiple updates in a single loop means that there are multiple changes with new resourceVersions floating around. This then leads to races where you might end up reconciling on the resource from after update1 when you really want the change from after update2. Since the two-updates was just an optimization, removed it.
Multiple updates in a single loop means that there are multiple changes with new resourceVersions floating around. This then leads to races where you might end up reconciling on the resource from after update1 when you really want the change from after update2.
Since the two-updates was just an optimization, removed it.