Limit concurrency of CI builds #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
Porges,
matthchr,
babbageclunk and
super-harsh
as code owners
super-harsh
reviewed
Aug 29, 2022
| @@ -114,8 +114,8 @@ jobs: | |||
| - name: Build docker image & build configuration YAML | |||
| run: | | |||
| container_id=${{steps.devcontainer.outputs.id}} | |||
| docker exec "$container_id" task controller:docker-build-and-save | |||
| docker exec "$container_id" task controller:run-kustomize-for-envtest | |||
| docker exec "$container_id" task controller:docker-build-and-save --concurrency 1 # limit concurrency because build machines are small | |||
There was a problem hiding this comment.
Wouldn't this hit timeout/take too much time while running the tests in parallel?
There was a problem hiding this comment.
If our build machines were highly spec'd, limiting concurrency to just one task at a time would leave processors idle and memory unused. But we know from experience that the build machines are small, just two vCPU's, and so my hypothesis is that running too many tasks at the same time results in them fighting for resources and everything gets slowed down.
super-harsh
approved these changes
Aug 29, 2022
|
Based on some rudimentary testing, I think this makes some improvement.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Limits the concurrency of CI builds because the build machines are small and we suspect we are overloading them.
Special notes for your reviewer:
I'm hoping the CI build for this PR will run with the workflow modification included. If it doesn't, we'll need to merge this, and then run some tests.
How does this PR make you feel:
