Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved a few trailing dot issues #2248

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Resolved a few trailing dot issues #2248

merged 7 commits into from
Jun 20, 2023

Conversation

gapra-msft
Copy link
Member

@gapra-msft gapra-msft commented Jun 8, 2023 •
edited
Loading

  1. Fixed an issue where source trailing dot header was passed when source for a S2S copy is not file service
  2. Gracefully handle File Share trailing dot paths to Windows/Blob (that do not support trailing dot) by skipping such files
  3. Allow trailing dot option to be ignored instead of erroring out in situations it does not apply.

@gapra-msft gapra-msft added the bug label Jun 9, 2023
@gapra-msft gapra-msft added this to the 10.20 milestone Jun 9, 2023
nakulkar-msft
nakulkar-msft approved these changes Jun 12, 2023
View reviewed changes
cmd/zc_pipeline_init.go Show resolved Hide resolved
@gapra-msft gapra-msft requested a review from nakulkar-msft June 12, 2023 20:18
@gapra-msft gapra-msft changed the title Fixed an issue where source trailing dot header was passed when sourc… Resolved a few trailing dot issues Jun 13, 2023
@gapra-msft gapra-msft force-pushed the gapra/trailingdot-nonfilesource branch from 1fc0feb to 096d32e Compare June 13, 2023 17:54
adreed-msft
adreed-msft approved these changes Jun 16, 2023
View reviewed changes
cmd/zc_traverser_file.go Show resolved Hide resolved
cmd/zc_traverser_list.go Show resolved Hide resolved
@gapra-msft gapra-msft merged commit 23ff0ec into dev Jun 20, 2023
@gapra-msft gapra-msft deleted the gapra/trailingdot-nonfilesource branch June 20, 2023 15:51
@siminsavani-msft siminsavani-msft mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adreed-msft adreed-msft adreed-msft approved these changes

@tasherif-msft tasherif-msft tasherif-msft approved these changes

@siminsavani-msft siminsavani-msft Awaiting requested review from siminsavani-msft

@vibhansa-msft vibhansa-msft Awaiting requested review from vibhansa-msft vibhansa-msft is a code owner

@nakulkar-msft nakulkar-msft Awaiting requested review from nakulkar-msft

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
10.20
Development

Successfully merging this pull request may close these issues.
4 participants
@gapra-msft @adreed-msft @nakulkar-msft @tasherif-msft