Resolving 500 server timeouts on append blob appends #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
gapra-msft
changed the title
gapra-msft
changed the title
| @@ -68,14 +68,18 @@ func (u *appendBlobUploader) GenerateUploadFunc(id common.ChunkID, blockIndex in | |||
| u.jptm.LogChunkStatus(id, common.EWaitReason.Body()) | |||
| body := newPacedRequestBody(u.jptm.Context(), reader, u.pacer) | |||
| offset := id.OffsetInFile() | |||
| _, err := u.destAppendBlobClient.AppendBlock(u.jptm.Context(), body, | |||
| var timeoutFromCtx bool | |||
| ctx := withTimeoutNotification(u.jptm.Context(), &timeoutFromCtx) | |||
There was a problem hiding this comment.
why do we need context with timeout here, in older code its different right ?
There was a problem hiding this comment.
this is actually a notifier that a 500 status code was returned during the append block retries so we can check below. This is not adding a request timeout
tasherif-msft
approved these changes
Nov 27, 2023
siminsavani-msft
approved these changes
Nov 27, 2023
nakulkar-msft
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested GCP manually since pipeline GCP creds are not working