Fixed an issue where failure to rename a file from the temp prefix to the file name would not be considered a Failed transfer #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
siminsavani-msft
approved these changes
Dec 7, 2023
vibhansa-msft
approved these changes
Dec 8, 2023
tasherif-msft
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer was trying to download (from the blob service) a path with an empty directory and was seeing a successful transfer, but all affected files had the .azDownload temp prefix, which is unexpected.
Windows does not support empty directory names, and different APIs behave differently. Create/Delete will trim the extra / but Rename considers it to be an invalid path name.
This fix makes failure to rename the file be considered a Failed transfer.