Commands lagging for ~8 seconds due to version-check #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siminsavani-msft
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
vibhansa-msft,
tasherif-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
|
Could you describe the change in the description? |
|
@gapra-msft added description. |
gapra-msft
approved these changes
Dec 14, 2023
nakulkar-msft
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2482
Version check command lags for 8 seconds due to channel not being closed. This change ensures that whether the version is cached or not, the beginDetectNewVersion method exits properly allowing the channel to be closed at the end (line 317).