-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RCA Repair Item] Add exclude-container flag #2504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siminsavani-msft
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
tasherif-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
January 12, 2024 00:23
vibhansa-msft
previously approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment to add logs whenever we skip a container.
vibhansa-msft
approved these changes
Jan 15, 2024
nakulkar-msft
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers are unable to exclude containers when doing an Account to Account transfer. This PR introduces a new flag,
--exclude-path
that allows the user to add as many container names as they want to be excluded during Account to Account transfer.AzCopy sync does not support service level transfers and we spit out this error:
Failed with error service level URLs (https://xxx.blob.core.windows.net/) are not supported in sync:
, therefore, exclude-containers is not added to sync.AzCopy remove does also does not support deleting at service level. No error message is spit out but containers and blobs are not deleted after a simple
remove https://xxx.blob.core.windows.net/$[SAS]
so exclude-container is not added to remove. Specific containers can be removed by using the container URL.