Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logger name without suffix #2534

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Fix logger name without suffix #2534

merged 1 commit into from
Jan 14, 2024

Conversation

nakulkar-msft
Copy link
Contributor

Adds ".log" right when we create a log file, instead of adding it while rotation. KInd of like we used to do earlier.

Copy link
Contributor

@pranavmalik-msft pranavmalik-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pranavmalik-msft pranavmalik-msft self-requested a review January 10, 2024 13:54
@nakulkar-msft nakulkar-msft merged commit 88acd6c into dev Jan 14, 2024
17 checks passed
@nakulkar-msft nakulkar-msft deleted the nakulkar/private/logger3 branch January 15, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log files are missing .log extension
4 participants