Preserve the snapshot ID when testing for required auth on MD #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
tasherif-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
gapra-msft
reviewed
Feb 8, 2024
gapra-msft
previously approved these changes
Feb 8, 2024
siminsavani-msft
previously approved these changes
Feb 12, 2024
tasherif-msft
previously approved these changes
Feb 14, 2024
adreed-msft
force-pushed
the
adreed/md-snapshot-fix
branch
from
3cf43d5 to
ef5cda7
Compare
adreed-msft
dismissed stale reviews from tasherif-msft, siminsavani-msft, and gapra-msft
The base branch was changed.
adreed-msft
force-pushed
the
adreed/md-snapshot-fix
branch
from
bc64932 to
cf2e7ce
Compare
gapra-msft
approved these changes
Mar 12, 2024
tasherif-msft
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When supplying a managed disk SAS token, we would historically trim the snapshot (as expected with blob), but this is unnecessary and problematic with managed disk snapshots, where managed disks expect the snapshot as a part of the authorization. When we check for MD auth, we should preserve the snapshot ID, because it is a portion of auth.
This PR includes code changes and tests for both data access authentication mode ("OAuth + SAS") and non-authenticated data access (just a SAS).