-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaned up logs #2602
cleaned up logs #2602
Conversation
@microsoft-github-policy-service agree |
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- I'd like to suggest you take a look at the json output and see if it fits your needs better than regex'ing the human-readable output.
--output-type=json
, I believe is documented in the root command. If not, we'd really love to hear your feedback on what makes the json output hard to use. - Technically this could break other people in the same process, but imo, automation customers should be using computer-readable output schemes anyway.
Overall, this is a good set of changes-- human readable schemes shouldn't be taking on field names directly, anyway.
Occasionally, I need to extract logs using regex, but there is an inconvenience due to the inconsistency of string messages in the generated .log file. To address this issue, I've added changes in the show, sync, resume, and copy files, ensuring consistent casing and spacing for messages like these:
TotalBytesTransferred ---> Total Number of Bytes Transferred
Total Number Of Copy Transfers ---> Total Number of Copy Transfers