Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Supportability] Improve error message when performing uploads with a missing SAS token #2644

Merged
merged 5 commits into from
Apr 24, 2024
Merged

[Supportability] Improve error message when performing uploads with a missing SAS token #2644

merged 5 commits into from
Apr 24, 2024

Conversation

siminsavani-msft
Copy link
Contributor

@siminsavani-msft siminsavani-msft commented Apr 8, 2024 •
edited
Loading

INFO messages are updated to indicate preferred authentication methods, given that credential type is Unknown and resource is Azure.

INFO: Scanning...
INFO: Autologin not specified.
INFO: Authenticating to destination using Unknown, Please authenticate using Microsoft Entra ID (https://aka.ms/AzCopy/AuthZ), use AzCopy login, or append a SAS token to your Azure URL.
INFO: Authenticating to source using Unknown, Please authenticate using Microsoft Entra ID (https://aka.ms/AzCopy/AuthZ), use AzCopy login, or append a SAS token to your Azure URL.

@siminsavani-msft siminsavani-msft marked this pull request as ready for review April 17, 2024 16:47
@siminsavani-msft siminsavani-msft added this to the 10.25.0 milestone Apr 17, 2024
adreed-msft
adreed-msft approved these changes Apr 23, 2024
View reviewed changes
cmd/credentialUtil.go Outdated Show resolved Hide resolved
e2etest/zt_newe2e_basic_functionality_test.go Outdated Show resolved Hide resolved
@gapra-msft gapra-msft merged commit db17374 into main Apr 24, 2024
17 checks passed
@siminsavani-msft siminsavani-msft deleted the siminsavani/usability-missing-sas branch April 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gapra-msft gapra-msft gapra-msft approved these changes

@adreed-msft adreed-msft adreed-msft approved these changes

@nakulkar-msft nakulkar-msft Awaiting requested review from nakulkar-msft

@vibhansa-msft vibhansa-msft Awaiting requested review from vibhansa-msft vibhansa-msft is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@pranavmalik-msft pranavmalik-msft Awaiting requested review from pranavmalik-msft

Assignees

@adreed-msft adreed-msft

@gapra-msft gapra-msft

Labels
None yet
Projects
None yet
Milestone
10.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@siminsavani-msft @adreed-msft @gapra-msft