Fixed issue in pipeline network stats where short job stats would never get populated #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
adreed-msft
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline Network Stats do not start to get populated until the tuner reaches a stable point. For short jobs, this can result in no stats being reported. For long jobs, this results in inaccurate results being reported since stats before tuner stability are not counted at all.
This PR starts population of pipeline network stats from the conception of the job. All stats reported are averages, so this change should only marginally affect long jobs and will now start reporting stats for short jobs.