Check for both folder
and folder/
as hdi_isfolder blobs
#2809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation was designed against an HNS account, not a FNS account, and was almost always tested against HNS.
On HNS, if you were using the
blob
endpoint, and you listed, you wouldn't get returned folder stub blobs. You'd have to manually ping them for properties. Two things happened because of this.folder
.folder
twice working against blob on FNS, because it'd now appear inside the listed items. This would cause a panic, because we'd try to deschedule a successful folder twice.A third problem arose with certain customers, where they were following this format, but misunderstood it, and actually named their folders
folder/
. In this case, we'd findfolder/
normally, and it'd function like expected. But the original code wasn't explicitly checking for it.So the solution is, always ignore the folder blobs when we're sent them as list items. Always check both
folder
andfolder/
. This means we'll always catch it, even on HNS.