Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for both folder and folder/ as hdi_isfolder blobs #2809

Merged
merged 10 commits into from
Oct 21, 2024

Conversation

adreed-msft
Copy link
Member

The old implementation was designed against an HNS account, not a FNS account, and was almost always tested against HNS.

On HNS, if you were using the blob endpoint, and you listed, you wouldn't get returned folder stub blobs. You'd have to manually ping them for properties. Two things happened because of this.

  1. We manually checked for folder.
  2. We could schedule folder twice working against blob on FNS, because it'd now appear inside the listed items. This would cause a panic, because we'd try to deschedule a successful folder twice.

A third problem arose with certain customers, where they were following this format, but misunderstood it, and actually named their folders folder/. In this case, we'd find folder/ normally, and it'd function like expected. But the original code wasn't explicitly checking for it.

So the solution is, always ignore the folder blobs when we're sent them as list items. Always check both folder and folder/. This means we'll always catch it, even on HNS.

cmd/copy.go Outdated Show resolved Hide resolved
@gapra-msft gapra-msft merged commit a16fe8a into main Oct 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants