Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for trailing dot transfers to unsafe locations #2827

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Added support for trailing dot transfers to unsafe locations #2827

wants to merge 26 commits into from
+289 −62

Conversation

wonwuakpa-msft
Copy link
Collaborator

@wonwuakpa-msft wonwuakpa-msft commented Oct 10, 2024 •
edited
Loading

PR made to address this customer issue concerning transferring trailing dot files. Windows natively does not support trailing dots in filenames, so a (initially just Enable and Disable) third option AllowToUnsafeDestination was added to AzCopy to enable this functionality.

  • Updated the documentation to include the feature
  • Tests using the E2E framework were added for this additional trailing dot AllowToUnsafeDestination option
  • Persisted the trailingDotOption information when the job is resumed
  • Update the code to prevent nil dereference error from one of the tests

adreed-msft and others added 13 commits September 24, 2024 12:42
adreed-msft
adreed-msft approved these changes Oct 23, 2024
View reviewed changes
cmd/jobsResume.go Show resolved Hide resolved
cmd/jobsResume.go Show resolved Hide resolved
cmd/zc_traverser_file.go Show resolved Hide resolved
gapra-msft
gapra-msft reviewed Nov 11, 2024
View reviewed changes
cmd/copy.go Outdated Show resolved Hide resolved
gapra-msft
gapra-msft reviewed Nov 11, 2024
View reviewed changes
ste/jobStatusManager.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gapra-msft gapra-msft gapra-msft left review comments

@adreed-msft adreed-msft adreed-msft approved these changes

@dphulkar-msft dphulkar-msft Awaiting requested review from dphulkar-msft dphulkar-msft is a code owner

@vibhansa-msft vibhansa-msft Awaiting requested review from vibhansa-msft vibhansa-msft is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@souravgupta-msft souravgupta-msft Awaiting requested review from souravgupta-msft souravgupta-msft is a code owner

@tanyasethi-msft tanyasethi-msft Awaiting requested review from tanyasethi-msft tanyasethi-msft is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@adreed-msft adreed-msft

@gapra-msft gapra-msft

Labels
pr-ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wonwuakpa-msft @adreed-msft @gapra-msft