Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

QueueRequestOptions.ApplyDefaults does not apply default NetworkTimeout #999

Closed
brettsam opened this issue Jun 1, 2020 · 1 comment · Fixed by #1000
Closed

QueueRequestOptions.ApplyDefaults does not apply default NetworkTimeout #999

brettsam opened this issue Jun 1, 2020 · 1 comment · Fixed by #1000

Comments

@brettsam
Copy link
Member

brettsam commented Jun 1, 2020

If you look here -- there's no default NetworkTimeout applied: https://github.com/Azure/azure-storage-net/blob/master/Lib/Common/Queue/QueueRequestOptions.cs#L82, so if you pass null options in you don't get any timeout behavior and can result in a deadlock (fixed by #985).

Other requestOptions apply the default:

FYI @kasobol-msft
This was referenced Jun 1, 2020
Closed
Merged
@kasobol-msft kasobol-msft mentioned this issue Jun 1, 2020
Merged
@kasobol-msft
Copy link
Contributor

Fix released in https://www.nuget.org/packages/Microsoft.Azure.Storage.Queue/11.1.7

@TheTomMark TheTomMark mentioned this issue Jun 11, 2020
Closed
benoutram added a commit to dfe-analytical-services/explore-education-statistics that referenced this issue Jul 10, 2020
@benoutram
EES-1009 Upgrade to .NET Core 3.1
fbff4d2 
- Target .NET Core 3.1
- Target Azure function runtime 3.0 rather than 3.0 Preview
- Dependency upgrades
- Update Azure Storage dependencies.
- Use generic host for app services (recommended in 3.0+)
- Disable sensitive data logging
- Remove the HostingStartup dependency added by EES-1061
- Remove Backend Build SDK installation tasks for older versions. Change to using vm image label.
- Use 3.1.x SDK for Admin Build
- Remove unsupported Logger injection in Content API Startup
- Temporarily add Publisher dependency on Microsoft.Azure.Storage.File to fix Azure/azure-storage-net#999
@benoutram benoutram mentioned this issue Jul 10, 2020
Merged
benoutram added a commit to dfe-analytical-services/explore-education-statistics that referenced this issue Jul 20, 2020
@benoutram
EES-1009 Upgrade to .NET Core 3.1
0bfe4d8 
- Target .NET Core 3.1
- Target Azure function runtime 3.0 rather than 3.0 Preview
- Dependency upgrades
- Update Azure Storage dependencies.
- Use generic host for app services (recommended in 3.0+)
- Disable sensitive data logging
- Remove the HostingStartup dependency added by EES-1061
- Remove Backend Build SDK installation tasks for older versions. Change to using vm image label.
- Use 3.1.x SDK for Admin Build
- Remove unsupported Logger injection in Content API Startup
- Temporarily add Publisher dependency on Microsoft.Azure.Storage.File to fix Azure/azure-storage-net#999
benoutram added a commit to dfe-analytical-services/explore-education-statistics that referenced this issue Jul 20, 2020
@benoutram
EES-1009 Upgrade to .NET Core 3.1 (#1762)
239e80b 
* EES-1009 Upgrade to .NET Core 3.1
- Target .NET Core 3.1
- Target Azure function runtime 3.0 rather than 3.0 Preview
- Dependency upgrades
- Update Azure Storage dependencies.
- Use generic host for app services (recommended in 3.0+)
- Disable sensitive data logging
- Remove the HostingStartup dependency added by EES-1061
- Remove Backend Build SDK installation tasks for older versions. Change to using vm image label.
- Use 3.1.x SDK for Admin Build
- Remove unsupported Logger injection in Content API Startup
- Temporarily add Publisher dependency on Microsoft.Azure.Storage.File to fix Azure/azure-storage-net#999
benoutram added a commit to dfe-analytical-services/explore-education-statistics that referenced this issue Jul 31, 2020
@benoutram
EES-1009 Upgrade to .NET Core 3.1 (#1762)
ef74ef2 
* EES-1009 Upgrade to .NET Core 3.1
- Target .NET Core 3.1
- Target Azure function runtime 3.0 rather than 3.0 Preview
- Dependency upgrades
- Update Azure Storage dependencies.
- Use generic host for app services (recommended in 3.0+)
- Disable sensitive data logging
- Remove the HostingStartup dependency added by EES-1061
- Remove Backend Build SDK installation tasks for older versions. Change to using vm image label.
- Use 3.1.x SDK for Admin Build
- Remove unsupported Logger injection in Content API Startup
- Temporarily add Publisher dependency on Microsoft.Azure.Storage.File to fix Azure/azure-storage-net#999
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply default network timeout to queue options. kasobol-msft/azure-storage-net
2 participants
@brettsam @kasobol-msft