Added example modules-vwan-to-vnet-s2s-with-fw

[StefanIvemo]

Added Bicep example using modules.

Deploys:

• Azure Virtual WAN + Hub + VPN GW and Azure Firewall
• Hub Virtual Network + NSGs + VPN GW + Azure Firewall + IP Prefix
• Site-to-site tunnel between VNet and vHub

[StefanIvemo]

Looks like the checks are failing due to the build warnings because of the API Spec for Microsoft.Network/connections. Reported in the #784 issue.

[alex-frankel]

Looks like most of the test failures are occurring because of formatting issues. You can use the formatter built into the bicep extension to match what the test are expecting. Please note there is a known issue where our formatter is removing the last blank newline, even though the test is expecting that, so you will need to add these manually.

You can run dotnet test locally to run the same tests that are run when a PR is submitted, which can help you verify the fixes.

[StefanIvemo]

@alex-frankel added blank new lines in all bicep files and added empty properties: {} objects in the Microsoft.Network/connections resource to get rid of the build warnings.

[alex-frankel]

thanks for getting the tests resolved. Have some small nitpicks/questions, but otherwise looks good.

Will give you a day to review, but then will merge

[codecov-io]

Codecov Report

Merging #1018 (5804356) into main (a0a38b2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         328      328           
  Lines       15810    15811    +1     
  Branches       12       12           
=======================================
+ Hits        14903    14904    +1     
  Misses        907      907           

Flag	Coverage Δ
dotnet	94.82% <ø> (+<0.01%)	⬆️
typescript	25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Bicep.Core.Samples/ExamplesTests.cs	98.73% <0.00%> (+0.01%)	⬆️

[StefanIvemo]

@alex-frankel thanks for the remarks! Looked over the example again and cleaned it up, looks better now.

[alex-frankel]

thanks!