Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write "{}" for config (breaking change, 11482) #12057

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Oct 5, 2023

Fixes #11482

This is a breaking change that keeps v0.20 or earlier from restoring modules published with versions with this change.

The original breaking change notification doesn't seem to have made it into the release notes, but we can put this into the new version:

This is a breaking change in how modules are published. This change will affect v0.20 and earlier, keeping them from being able to restore modules created in v0.23 or later.
v0.20 or earlier: Can read modules published with v0.22 or earlier. Will get an error trying to restore a module published with v0.23 or later.
v0.21, v0.22: Can read modules published earlier or later. Modules published with v0.21 can be read by earlier and later versions.
v0.23: Can read modules published earlier or later. Modules published with v0.23 can be read by v0.21 and later.

Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Test this change out locally with the following install scripts (Action run 6423413006)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6423413006
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6423413006"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6423413006
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6423413006"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Test Results

     132 files  ±0       132 suites  ±0   3h 57m 33s ⏱️ - 2m 10s
10 667 tests ±0  10 667 ✔️ ±0  0 💤 ±0  0 ±0 
51 535 runs  ±0  51 535 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit f0e4d56. ± Comparison against base commit d7b6beb.

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford merged commit 144e00b into main Oct 5, 2023
47 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/11482 branch October 5, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make recommended changes to our module manifests (breaking change for v0.23)
2 participants