Correct terminating token for tuple parsing recovery #12140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12126
The terminating tokens passed to
WithRecovery
when parsing tuple type members were'\n'
and'}'
instead of'\n'
and']'
(likely due to a copy/paste error).This would cause the parser to hang when it encountered a
'}'
in a position where the parser expected a standalone type expression, as the parser would neither be able to parse the'}'
nor advance past it in https://github.com/Azure/bicep/blob/main/src/Bicep.Core/Parsing/BaseParser.cs#L1259-L1270Microsoft Reviewers: Open in CodeFlow