Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both provider and import keywords for extensibility statements #12281

Merged
merged 9 commits into from
Oct 27, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Oct 26, 2023

The provider keyword is preferred; using import will raise a warning diagnostic, but there are otherwise no behavioral changes expected from this PR.

Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Test this change out locally with the following install scripts (Action run 6667074779)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6667074779
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6667074779"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6667074779
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6667074779"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Test Results

     132 files  ±0       132 suites  ±0   4h 1m 43s ⏱️ - 10m 3s
10 680 tests +1  10 680 ✔️ +1  0 💤 ±0  0 ±0 
51 607 runs  +4  51 607 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit 597a46e. ± Comparison against base commit a5cf916.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@asilverman asilverman self-requested a review October 26, 2023 21:45
Copy link
Contributor

@asilverman asilverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeskew jeskew merged commit 7d38437 into main Oct 27, 2023
47 checks passed
@jeskew jeskew deleted the jeskew/provider-keyword branch October 27, 2023 12:18
jeskew added a commit that referenced this pull request Oct 27, 2023
Small follow-up to #12281 to improve error messaging on incomplete
`import` statements
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/12289)
itpropro added a commit to itpropro/bicep that referenced this pull request Mar 21, 2024
Fixing a probable oversight in the grammar definition from Azure#12281
@itpropro itpropro mentioned this pull request Mar 21, 2024
anthony-c-martin pushed a commit that referenced this pull request Mar 21, 2024
Fixing a probable oversight in the grammar definition from #12281
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants