Centralize imported symbol to ARM expression conversion #12405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12396
This PR updates the
TemplateWriter
andExpressionConverter
to handle imported symbols as they're being compiled to ARM expressions. Previously, imported symbols were replaced with anExpressionRewriteVisitor
at earlier stages of processing, but there are some top-level resource properties that are not captured in the IR and thus wouldn't get replaced.Microsoft Reviewers: Open in CodeFlow