Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Avoid emitting parameters if there are parse errors #12641

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix: Avoid emitting parameters if there are parse errors #12641

merged 1 commit into from
Dec 5, 2023

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Dec 5, 2023 •
edited by microsoft-github-policy-service bot
Loading

Closes #12640

Microsoft Reviewers: Open in CodeFlow

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) December 5, 2023 12:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023 •
edited
Loading

Test this change out locally with the following install scripts (Action run 7118720818)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7118720818
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7118720818"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7118720818
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7118720818"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Test Results

     132 files  ±0       132 suites  ±0   4h 40m 20s ⏱️ + 9m 42s
10 871 tests +1  10 868 ✔️  - 2  0 💤 ±0  3 ❌ +3 
52 407 runs  +4  52 404 ✔️ +1  0 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 164e2ed. ± Comparison against base commit 57a682d.

@anthony-c-martin anthony-c-martin changed the title Fix for issue 12640 Fix: Avoid emitting parameters if there are parse errors Dec 5, 2023
@anthony-c-martin anthony-c-martin merged commit 4fff342 into main Dec 5, 2023
46 of 47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue12640 branch December 5, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeskew jeskew jeskew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bicep.Core.Syntax.SkippedTriviaSyntax when referencing inside a bicepparam file
2 participants
@anthony-c-martin @jeskew