Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes to the bicep jsonrpc command #13051

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jan 21, 2024

  • Add type information to JSONRPC bicep/getMetadata parameters & outputs
  • Add new method bicep/getFileReferences to obtain a list of files that are referenced by a given file.
  • Set up tracing so that BICEP_TRACING_ENABLED configures verbose JSONRPC logging
  • Add JSONRPC command documentation.

May help with the implementation for #5715
Closes #12650

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jan 21, 2024

Test this change out locally with the following install scripts (Action run 7618307197)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7618307197
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7618307197"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7618307197
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7618307197"

Copy link
Contributor

github-actions bot commented Jan 21, 2024

Test Results

    66 files   -     33      66 suites   - 33   22m 59s ⏱️ - 28m 5s
10 636 tests  -     19  10 636 ✅  -     19  0 💤 ±0  0 ❌ ±0 
25 771 runs   - 12 881  25 771 ✅  - 12 881  0 💤 ±0  0 ❌ ±0 

Results for commit 95e2d3a. ± Comparison against base commit c7427c7.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Add type information to JSONRPC bicep/getMetadata method Various changes to the bicep jsonrpc command Jan 22, 2024
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 188a0bc into main Jan 22, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/jsonrpc branch January 22, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document bicep jsonrpc command
2 participants