Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use string.Method(char) instead of string.Method(string) when possible #14255

Conversation

Meir017
Copy link
Contributor

@Meir017 Meir017 commented Jun 9, 2024

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) June 9, 2024 19:25
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the code!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.71%. Comparing base (108d816) to head (18409b8).
Report is 617 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #14255       +/-   ##
===========================================
- Coverage   94.28%    7.71%   -86.57%     
===========================================
  Files        1113        7     -1106     
  Lines      100791      350   -100441     
  Branches     8734      125     -8609     
===========================================
- Hits        95028       27    -95001     
+ Misses       4595      322     -4273     
+ Partials     1168        1     -1167     
Flag Coverage Δ
dotnet ?
typescript 7.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1104 files with indirect coverage changes

@anthony-c-martin anthony-c-martin merged commit 9969aed into Azure:main Jun 9, 2024
37 of 38 checks passed
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Test this change out locally with the following install scripts (Action run 9439016547)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9439016547
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9439016547"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9439016547
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9439016547"

@Meir017 Meir017 deleted the chore/string-comparison-methods-with-single-char branch June 9, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants