Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly decompile negative numbers in TLEs #14317

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Correctly decompile negative numbers in TLEs #14317

merged 3 commits into from
Jun 17, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jun 13, 2024 •
edited
Loading

Closes #14306
Closes #14323

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 9541157701)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9541157701
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9541157701"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9541157701
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9541157701"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2024 •
edited
Loading

Dotnet Test Results

    72 files   -     36      72 suites   - 36   22m 50s ⏱️ - 12m 22s
10 881 tests  -     18  10 880 ✅  -     18  1 💤 ±0  0 ❌ ±0 
25 658 runs   - 12 819  25 656 ✅  - 12 818  2 💤  - 1  0 ❌ ±0 

Results for commit ae7026d. ± Comparison against base commit eae676e.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) June 13, 2024 19:48
@anthony-c-martin anthony-c-martin changed the title Fix for issue 14306 Correctly decompile negative numbers in TLEs Jun 13, 2024
@anthony-c-martin anthony-c-martin merged commit cfccdd1 into main Jun 17, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue14306 branch June 17, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeskew jeskew jeskew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decompile handles JSON float values incorrectly Unable to decompile negative numbers
2 participants
@anthony-c-martin @jeskew