Fix Intellisense and other features of Bicep in Visual Studio that were broken by VS 17.10

[StephenWeatherford]

Fixes #14316

VS 17.10 added support for language server capabilities. This means that it started firing notifications only for events that were explicitly requested by the client (which is normal and works in vscode). Unfortunately, their LSP implementation lacks support for document selectors based on language ID (they only support file patterns, language/scheme are NYI). This means it didn't recognize any of our registrations and VS was giving us virtually no notifications, e.g. for file changes. The fix is to use file patterns for VS, language/scheme for any other hosts including vscode.

I fixed this such that it should only affect the behavior in VS, not VsCode or other hosts, out of an abundance of caution (it would be possible to return language/scheme as well as file patterns, but it does cause minor behavior changes in vscode and would also mean VS behavior would change in minor ways again after this fix this problem - better to just make the behavior explicit for both hosts).

The actual fix is in DocumentSelectorFactory, almost all of the rest is just passing along the dependencies it needs to know when to apply the fix.

[github-actions]

Test this change out locally with the following install scripts (Action run 9965886474)

VSCode

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9965886474

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9965886474"

Azure CLI

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9965886474

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9965886474"

[AbhitejJohn]

Do we have tests/manual validation workflow to let us know early if this breaks in the future? I'm also curious if there is a set of partner tests/a process we can use so folks can reach out to us before these are broken. Even if that is us subscribed to the right breaking change notifications, that would be helpful as well.

[github-actions]

Dotnet Test Results

    72 files   -     36      72 suites   - 36   24m 5s ⏱️ - 8m 56s
10 955 tests  -     20  10 955 ✅  -     20  0 💤 ±0  0 ❌ ±0 
25 806 runs   - 12 899  25 806 ✅  - 12 899  0 💤 ±0  0 ❌ ±0 

Results for commit 7a83378. ± Comparison against base commit 9dc6238.

♻️ This comment has been updated with latest results.

[StephenWeatherford]

Do we have tests/manual validation workflow to let us know early if this breaks in the future?

@AbhitejJohn The manual weekly testing will easily catch this. Right now the section on completion notes that it's broken. I'll be updating and also adding a few more simple scenarios. Hopefully I can get the automated testing back online, soon, too.

[anthony-c-martin]

See comments

[anthony-c-martin]

LGTM!