Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid assigning invalid cyclic types to declarations #14874

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Avoid assigning invalid cyclic types to declarations #14874

merged 1 commit into from
Aug 22, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Aug 22, 2024 •
edited by microsoft-github-policy-service bot
Loading

Closes #14867

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 10509524080)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10509524080
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10509524080"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10509524080
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10509524080"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

Dotnet Test Results

   12 files   -     96     12 suites   - 96   2m 34s ⏱️ - 30m 57s
3 021 tests  -  8 043  3 021 ✅  -  8 042  0 💤 ±0  0 ❌  - 1 
3 023 runs   - 35 769  3 023 ✅  - 35 768  0 💤 ±0  0 ❌  - 1 

Results for commit 0cd2c5f. ± Comparison against base commit 68f9bca.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Fix for issue 14867 Avoid assigning invalid types to declarations Aug 22, 2024
@anthony-c-martin anthony-c-martin changed the title Avoid assigning invalid types to declarations Avoid assigning invalid cyclic types to declarations Aug 22, 2024
jeskew
jeskew approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jeskew jeskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad to see this check move from EmitLimitationCalculator.

@anthony-c-martin anthony-c-martin merged commit a19d748 into main Aug 22, 2024
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue14867 branch August 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeskew jeskew jeskew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fun with Dick and Jane and completion with invalid recursive types (server crashes)
2 participants
@anthony-c-martin @jeskew