Refactor: Use single Diagnostic class to represent all core diagnostics
#14875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 10532680475) VSCode
Azure CLI
|
anthony-c-martin
force-pushed
the
ant/diags
branch
from
ba33ad5
to
2dab2ec
Compare
anthony-c-martin
force-pushed
the
ant/diags
branch
from
2dab2ec
to
49bbaa7
Compare
anthony-c-martin
changed the title
Diagnostic class to represent all core diagnostics
|
|
||
| namespace Bicep.Core.Diagnostics; | ||
|
|
||
| public class ResultWithDiagnosticBuilder<TSuccess> : Result<TSuccess, DiagnosticBuilder.DiagnosticBuilderDelegate> |
There was a problem hiding this comment.
I appreciate the new name, this was confusing.
| @@ -228,8 +228,8 @@ private DeclaredTypeAssignment GetParameterType(ParameterDeclarationSyntax synta | |||
| if (!binder.FileSymbol.TryGetBicepFileSemanticModelViaUsing().IsSuccess(out var semanticModel, out var failureDiagnostic)) | |||
| { | |||
| // failed to resolve using | |||
| return failureDiagnostic is ErrorDiagnostic error | |||
| ? ErrorType.Create(error) | |||
| return failureDiagnostic.Level == DiagnosticLevel.Error | |||
There was a problem hiding this comment.
Might be worth it to have an IsErrorDiagnostic() or IsErrorLevel() extension for IDiagnostic.
There was a problem hiding this comment.
Good suggestion! I have a follow-up PR - will address this there.
StephenWeatherford
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split class structure between
ErrorDiagnostic&Diagnosticis something I've been meaning to remove since the very early days of Bicep. I've decided to do it now, because it'll simplify the refactor needed for #14842.The majority of the changes in this PR were made using refactoring tools, not manually. The main changes I made were:
ErrorDiagnostic,ErrorBuilderDelegate,FixableErrorDiagnosticdiag is ErrorDiagnostictype checks to usediag.Level == DiagnosticLevel.ErrorinsteadResultWithDiagnostictoResultWithDiagnosticBuilderinstead to more accurately represent its purposeResultWithDiagnotic<T>, and replaced usage ofResult<T, Diagnostic>with itMicrosoft Reviewers: Open in CodeFlow