-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow string literals in object property names #275
Conversation
We should also update the list of known issues in the readme which discusses this issue |
Will do |
d556562
to
26aa76e
Compare
{ | ||
var lineStarts = TextCoordinateConverter.GetLineStarts(sourceText); | ||
var newlineSequence = dataSet.HasCrLfNewlines() ? "\r\n" : "\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was writing back these files using StringBuilder.AppendLine, which uses different newline terminators depending on the platform (hence the huge diffs...). This will make it consistent cross-platform and avoid the huge diffs occurring again (sorry!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better now than later. Btw, CodeFlow shows "Edit" but no actual diff :)
In reply to: 474407770 [](ancestors = 474407770)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #249
Closes #145
Closes #156
Closes #206