Logic App Workflow and Integration Account Snippet

[rajyraman]

Snippet for Logic App workflow was creating Integration Account, and there was no snippet for Integration Account.

• I have a snippet that is either a single, generic resource or multi resource that uses parent-child syntax
• I have checked that there is not an equivalent snippet already submitted
• I have used camelCasing unless I have a justification to use another casing style
• I have placeholders values that correspond to their property names (e.g. dnsPrefix: 'dnsPrefix'), unless it's a property that MUST be changed or parameterized in order to deploy. In that case, I use 'REQUIRED' e.g. keyData
• I have my symbolic name as the first tab stop ($1) in the snippet. e.g. res-aks-cluster.bicep
• I have a resource name property equal to "name"

[miqm]

A suggestion - perhaps we could include in the snippet json(loadTextContent('{placeholder}')) for loading LogicApp definition from a file?

[rajyraman]

@miqm - I thought this is a simple fix, but I cannot get the tests working.

1. Complains about missing file
2. main.combined.bicep is always generated incorrectly

I am not sure what I am doing wrong.

[miqm]

@rajyraman It's not you, seems like snippet tests runner is trying to load the file while it should ignore it. It needs to be changes/fixed, I'll create issue for it and see what can be done.

[rajyraman]

@miqm - I can't believe that I could not see the missing '} 🤦. I am now getting this error.

Thank you fixing the underlying issue. I will test it with your PR.

[miqm]

Hey @rajyraman, both issues you've been experiencing are fixed, please rebase and try now.

[miqm]

Instead required put logicApp.json it has to be nam of the file with definition. In addition, remove the .definition from the end and from json file just leave object starting from schema.

[rajyraman]

@miqm - I can change the name, but CONTRIBUTING.md, says that I should use 'REQUIRED' if that property must be changed before deployment. All Logic Apps JSON's have definition property, and so I am mapping property to this definition property.

[miqm]

The thing is that there are 2 tests. One that uses mapping done in main.bicep and second that just compiles the snippet. Your code is failing with the second one as there is no REQUIRED file to be loaded.
@anthony-c-martin should we make an exemption from the REQUIRED rule and allow for parameter that needs to be changed different file name?

[anthony-c-martin]

@rajyraman - would you mind enabling "Allow edits from maintainers" for this PR, and I'll push the fixes for your tests.

[rajyraman]

@anthony-c-martin - It seems to be already enabled.

[anthony-c-martin]

Thanks for contributing!