In-lining Resources and Modules when assigned to a variable #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miqm
force-pushed
the
fix/generating-invalid-variable-1545
branch
from
1005ac7
to
a8fefd1
Compare
…lid-variable-1545
Comment on lines
289
to
296
| if (this.currentDeclaration is not null) | ||
| { | ||
| this.shouldInlineCache[this.currentDeclaration] = !shouldNotInline; | ||
| if (shouldNotInline) | ||
| { | ||
| this.shouldNotInlineCache.Add(this.currentDeclaration); | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm assuming this logic is to differentiate the default (don't inline) from an explicit decision not to inline. Rather than introducing 2 caches, would it be possible to modify to use a single cache with an enum - e.g. values to indicate "NotEvaluated", "Inline", "DoNotInline"?
There was a problem hiding this comment.
I added enum with NotInline, Inline and SkipInline values.
Comment on lines
-591
to
-623
| // referencing a module directly should be blocked at an earlier stage - there is nothing great we can codegen here. | ||
| Debug.Fail("Found direct module variable access"); |
There was a problem hiding this comment.
I've created #4320 just to make sure we keep track of the original problem.
…lid-variable-1545
…lid-variable-1545
…lid-variable-1545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1545
Fixes #4331
Contributing a feature