support digests in br module references
#5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,21 +29,35 @@ public class OciArtifactModuleReference : ModuleReference | |||
| // must be kept in sync with the tag max length | |||
| private static readonly Regex TagRegex = new(@"^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$", RegexOptions.Compiled | RegexOptions.ExplicitCapture | RegexOptions.CultureInvariant); | |||
|
|
|||
| private static readonly Regex DigestRegex = new(@"^sha256:[a-f0-9]{64}$", RegexOptions.Compiled | RegexOptions.ExplicitCapture | RegexOptions.CultureInvariant); | |||
There was a problem hiding this comment.
Does the OCI spec support upper-case hex letters?
There was a problem hiding this comment.
Not for sha256 and sha512 digest algorithms. It is theoretically allowed for other algorithms, but those algorithms are not considered "registered" by the spec. And even then, both ACR and Bicep just assume sha256 for now.
anthony-c-martin
approved these changes
Oct 29, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4741.
The reference syntax is the following:
bicep publishwill reject digests in values of the--targetparameter.