Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added --allowoverwrite flag to decompile #6029

Merged
merged 6 commits into from
May 4, 2022

Conversation

vlahane
Copy link
Contributor

@vlahane vlahane commented Feb 20, 2022

Fixes: #5659

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

  • I have checked that all tests are passing by running dotnet test for bicep CLI unit tests
  • I have Locally tested bicep decompile command with newly added flag.

@ghost
Copy link

ghost commented Feb 20, 2022

CLA assistant check
All CLA requirements met.

@StephenWeatherford
Copy link
Contributor

Looks like a test needs fixing or updating.

@vlahane
Copy link
Contributor Author

vlahane commented Apr 11, 2022

updated the test.

@StephenWeatherford
Copy link
Contributor

StephenWeatherford commented Apr 11, 2022

Thanks! Sending the bug through triage to verify the exact behavior we want (see #5659 (comment)). I think your PR is the right behavior, but it is a breaking change.

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes. Also awaiting decision from triage on desired behavior.

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Only one remaining item... We need testcases for the new functionality. I'd suggested adding the following two scenarios to. DecompileCommandTests.cs:

Decompile_OutputFileExists_ShouldFail
Decompile_OutputFileExists_Force_ShouldSuccess

Again, let me know if you'd like help or don't have time. Thanks!

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StephenWeatherford StephenWeatherford enabled auto-merge (squash) May 4, 2022 05:18
@StephenWeatherford StephenWeatherford merged commit 347d48f into Azure:main May 4, 2022
@vlahane vlahane deleted the vishal-overwrite-flag branch March 24, 2023 09:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az bicep decompile should not overwrite existing files without confirmation
2 participants