Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added private endpoint Bicep snippet #7929

Merged
merged 12 commits into from
Aug 20, 2022

Conversation

johnlokerse
Copy link
Contributor

@johnlokerse johnlokerse commented Aug 10, 2022

Contributing a snippet

  • I have a snippet that is either a single, generic resource or multi resource that uses parent-child syntax
  • I have checked that there is not an equivalent snippet already submitted
  • I have used camelCasing unless I have a justification to use another casing style
  • I have placeholders values that correspond to their property names (e.g. dnsPrefix: 'dnsPrefix'), unless it's a property that MUST be changed or parameterized in order to deploy. In that case, I use 'REQUIRED' e.g. keyData
  • I have my symbolic name as the first tab stop ($1) in the snippet. e.g. res-aks-cluster.bicep
  • I have a resource name property equal to "name"
  • If applicable, I have set the location property to location: /*${<id>:location}*/'location' (not resourceGroup().location) where <id> is a placeholder id, and added param location string to the test's main.bicep file so that the resulting main.combined.bicep file used in the tests compiles without errors
  • I have verified that the snippet deploys correctly when used in the context of an actual bicep file
Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) August 11, 2022 13:21
auto-merge was automatically disabled August 16, 2022 15:26

Head branch was pushed to by a user without write access

@anthony-c-martin
Copy link
Member

@johnlokerse Isn't location a required property for this resource type?

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@johnlokerse
Copy link
Contributor Author

@johnlokerse Isn't location a required property for this resource type?

Yes, you are right. Documentation didn't say (required), but tested it during a deployment and the output said 'location' is required. Added it back & ran dotnet test to fix the declaration.json.

@anthony-c-martin anthony-c-martin merged commit 57f3f59 into Azure:main Aug 20, 2022
@anthony-c-martin
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants