Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bicep visual studio extension name #8303

Merged
merged 6 commits into from
Sep 10, 2022

Conversation

bhsubra
Copy link
Contributor

@bhsubra bhsubra commented Sep 8, 2022

Update bicep visual studio extension name to - Bicep for Visual Studio.

The reason for this change is to avoid clash with the bicep vscode extension.

image

Microsoft Reviewers: Open in CodeFlow

@majastrz
Copy link
Member

majastrz commented Sep 9, 2022

@bhsubra @StephenWeatherford Is the package ID visible anywhere in Visual Studio? If yes, we should probably simplify it and make it closer to the VS Code package ID.

@bhsubra
Copy link
Contributor Author

bhsubra commented Sep 9, 2022

@bhsubra @StephenWeatherford Is the package ID visible anywhere in Visual Studio? If yes, we should probably simplify it and make it closer to the VS Code package ID.

@majastrz, are you referring to the below?
image

@majastrz
Copy link
Member

majastrz commented Sep 9, 2022

@bhsubra @StephenWeatherford Is the package ID visible anywhere in Visual Studio? If yes, we should probably simplify it and make it closer to the VS Code package ID.

@majastrz, are you referring to the below? image

Yeah

@bhsubra
Copy link
Contributor Author

bhsubra commented Sep 9, 2022

@bhsubra @StephenWeatherford Is the package ID visible anywhere in Visual Studio? If yes, we should probably simplify it and make it closer to the VS Code package ID.

@majastrz, are you referring to the below? image

Yeah

@majastrz , I checked a bunch of visual studio and vscode extensions on marketplace. I don't see 'Unique Identifier' on VS ones. I wonder if it's only for vscode.

@bhsubra
Copy link
Contributor Author

bhsubra commented Sep 9, 2022

@bhsubra @StephenWeatherford Is the package ID visible anywhere in Visual Studio? If yes, we should probably simplify it and make it closer to the VS Code package ID.

@majastrz, are you referring to the below? image

Yeah

@majastrz , I checked a bunch of visual studio and vscode extensions on marketplace. I don't see 'Unique Identifier' on VS ones. I wonder if it's only for vscode.

Per this documentation - https://docs.microsoft.com/en-us/visualstudio/extensibility/vsix-extension-schema-2-0-reference?view=vs-2022#metadata-element, ID is unique to the package. I am not sure if having a '-' in the name will create issues while uploading. I updated to match the vscode unique Id here:
e0e3886

@bhsubra
Copy link
Contributor Author

bhsubra commented Sep 10, 2022

@majastrz, I'll go ahead and merge the changes. Let me know if you have any concerns and I'll address them in a follow up PR. Thanks!

@bhsubra bhsubra merged commit 467dcad into main Sep 10, 2022
@bhsubra bhsubra deleted the dev/bhsubra/UpdateVSExtensionName branch September 10, 2022 03:32
@majastrz
Copy link
Member

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants