-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bicep visual studio extension name #8303
Conversation
src/vs-bicep/Bicep.VSLanguageServerClient.Vsix/source.extension.vsixmanifest
Outdated
Show resolved
Hide resolved
src/vs-bicep/Bicep.VSLanguageServerClient.Vsix/source.extension.vsixmanifest
Outdated
Show resolved
Hide resolved
@bhsubra @StephenWeatherford Is the package ID visible anywhere in Visual Studio? If yes, we should probably simplify it and make it closer to the VS Code package ID. |
@majastrz, are you referring to the below? |
Yeah |
@majastrz , I checked a bunch of visual studio and vscode extensions on marketplace. I don't see 'Unique Identifier' on VS ones. I wonder if it's only for vscode. |
Per this documentation - https://docs.microsoft.com/en-us/visualstudio/extensibility/vsix-extension-schema-2-0-reference?view=vs-2022#metadata-element, ID is unique to the package. I am not sure if having a '-' in the name will create issues while uploading. I updated to match the vscode unique Id here: |
@majastrz, I'll go ahead and merge the changes. Let me know if you have any concerns and I'll address them in a follow up PR. Thanks! |
Sounds good! |
Update bicep visual studio extension name to - Bicep for Visual Studio.
The reason for this change is to avoid clash with the bicep vscode extension.
Microsoft Reviewers: Open in CodeFlow