Published Bicep modules now include artifactType in the OCI manifest
#9520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeskew
reviewed
Jan 12, 2023
| @@ -56,7 +56,7 @@ public async Task<OciArtifactResult> PullArtifactAsync(RootConfiguration configu | |||
| return new OciArtifactResult(manifestDigest, manifest, manifestStream, moduleStream); | |||
| } | |||
|
|
|||
| public async Task PushArtifactAsync(Configuration.RootConfiguration configuration, OciArtifactModuleReference moduleReference, StreamDescriptor config, params StreamDescriptor[] layers) | |||
| public async Task PushArtifactAsync(RootConfiguration configuration, OciArtifactModuleReference moduleReference, string? artifactType, StreamDescriptor config, params StreamDescriptor[] layers) | |||
There was a problem hiding this comment.
Should artifactType be non-nullable here if all modules published with Bicep >= 0.14 will include it?
There was a problem hiding this comment.
I needed to push an artifact without artifactType in one of the tests I added to ensure we can successfully pull modules pushed by previous versions of Bicep (which won't have artifactType set).
jeskew
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new field in the OCI manifest called
artifactTypethat will help us support completions for modules published to container registries. From now on, Bicep will include that field in the OCI manifests we generate. I've also added tests to ensure that modules published by versions of Bicep that don't setartifactTypewill restore as before.Reference to OCI spec: https://github.com/opencontainers/image-spec/blob/main/artifact.md
Microsoft Reviewers: Open in CodeFlow