-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y][Theme]Mark color inverted inside Dark Partial theme #4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmyL219
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
June 14, 2024 22:19
Chat bundle size is increased❗.
|
Calling bundle size is increased❗.
|
CallWithChat bundle size is increased❗.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
approved these changes
Jun 18, 2024
dmceachernmsft
approved these changes
Jun 18, 2024
carocao-msft
approved these changes
Jun 18, 2024
AmyL219
changed the title
[A11y][Theme]Mark color inverted inside Dark theme
[A11y][Theme]Mark color inverted inside Dark Partial theme
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The dark theme is not working as expected because we missed setting the isInverted property in the dark theme. This oversight causes the colors to not invert properly, which is necessary for a true dark theme experience.
Solution
To resolve this issue, we need to use the createTheme(..) Currently, our darkTheme API is defined as
Adding the missing property to invert color would update the
darkTheme
API toBy adding the missing isInverted property, we can update the darkTheme API to properly invert the colors. However, to avoid breaking changes to the public API, we can create the full theme using createTheme and then define it as a PartialTheme.
This change ensures that the dark theme colors are properly inverted, providing the intended dark theme experience. By using createTheme, we avoid breaking changes to the public API while still achieving the necessary theme adjustments.
Q&A to confirm the Impact of creating the full theme using createTheme and then defining it as a PartialTheme in public API
Why
Our components has wrong color for those color not manually updated in the dark theme
How Tested
Login with v-id
navigate using keyboard only.
Select 'Dark' theme from 'Home' screen.
Process & policy checklist
Is this a breaking change?