Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Purview Role Assignment & Storage Access Rules #213

Merged
merged 7 commits into from
Dec 6, 2021
Merged

Added Purview Role Assignment & Storage Access Rules #213

merged 7 commits into from
Dec 6, 2021

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Nov 23, 2021 •
edited
Loading

This PR fixes

  • Added storage resource access rules for Synapse workspaces and Purview account
  • Added Purview role assignment to subscription as Storage Blob Data Rader and Reader to be able to scan all storage accounts and dedicated SQL Pools
  • Moved some docs
  • Linting

@marvinbuss marvinbuss added feature Feature Requests committed Committed item labels Nov 23, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Nov 23, 2021
@marvinbuss marvinbuss self-assigned this Nov 23, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner November 23, 2021 10:56
@marvinbuss
* updated workflow
9f0b87b 
* updated linting rules
@marvinbuss
* moved docs
ea19c2a 
* updated role assignment
* updated conditions
* added docs (role assignments)
@marvinbuss
linting
ca0285c
marvinbuss
marvinbuss commented Nov 26, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
Copy link
Collaborator Author

Preview Link

amanjeetsingh
amanjeetsingh reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates; see comments for more details.

docs/guidance/EnterpriseScaleAnalytics-DatabricksManualSetup.md Outdated Show resolved Hide resolved
marvinbuss
marvinbuss commented Nov 29, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marvinbuss
marvinbuss commented Dec 6, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss requested review from esbran and sasever December 6, 2021 14:33
sasever
sasever approved these changes Dec 6, 2021
View reviewed changes
Copy link

@sasever sasever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good To Go

@marvinbuss marvinbuss merged commit 1428f94 into main Dec 6, 2021
@marvinbuss marvinbuss deleted the marvinbuss/purview_integration branch December 6, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasever sasever sasever approved these changes

@amanjeetsingh amanjeetsingh Awaiting requested review from amanjeetsingh

@esbran esbran Awaiting requested review from esbran

Assignees

@marvinbuss marvinbuss

Labels
committed Committed item feature Feature Requests
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinbuss @amanjeetsingh @sasever