Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SHIR Deployment via Custom Data #214

Merged
merged 6 commits into from
Dec 6, 2021
Merged

Added SHIR Deployment via Custom Data #214

merged 6 commits into from
Dec 6, 2021

Conversation

marvinbuss
Copy link
Collaborator

This PR fixes

  • Install SHIR via Custom Data and Custom Script Extension
  • Removed unnecessary input parameters in parameter files, portal UI & docs
  • Simplified CI/CD pipelines
  • Removed old outputs
  • Updated VMSS to Windows Server 2022
  • Removed Artifact Storage

@marvinbuss marvinbuss added enhancement New feature or request committed Committed item labels Nov 26, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Nov 26, 2021
@marvinbuss marvinbuss self-assigned this Nov 26, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner November 26, 2021 12:16
@marvinbuss marvinbuss linked an issue Nov 26, 2021 that may be closed by this pull request
Feature Request: Install SHIR via Custom Data #188
Closed
marvinbuss
marvinbuss commented Nov 26, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marvinbuss
marvinbuss commented Nov 26, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
Copy link
Collaborator Author

Preview Link

amanjeetsingh
amanjeetsingh reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks required; see comments. Thanks

docs/EnterpriseScaleAnalytics-GitHubActionsDeployment.md Outdated Show resolved Hide resolved
docs/EnterpriseScaleAnalytics-GitHubActionsDeployment.md Outdated Show resolved Hide resolved
marvinbuss
marvinbuss commented Nov 29, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sasever
Copy link

sasever commented Dec 6, 2021

@marvinbuss the tests are done with:
parameters: /home/runner/work/data-landing-zone/data-landing-zone/infra/params.dev.json administratorPassword="***" deploySelfHostedIntegrationRuntimes=false

Are you sure that whole custom data deployment workflow is executed in test?

@marvinbuss
Copy link
Collaborator Author

@sasever please check under "Files changed":
image
This was updated in this branch.

Full test deployment with ADO was also executed:
image

marvinbuss
marvinbuss commented Dec 6, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @sasever for the heads up and for noticing these small bugs!

sasever
sasever approved these changes Dec 6, 2021
View reviewed changes
Copy link

@sasever sasever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legitimate. Thank you for fixing the last changes.

@marvinbuss marvinbuss merged commit 470ef18 into main Dec 6, 2021
@marvinbuss marvinbuss deleted the marvinbuss/shir_custom_data branch December 6, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasever sasever sasever approved these changes

@amanjeetsingh amanjeetsingh Awaiting requested review from amanjeetsingh

Assignees

@marvinbuss marvinbuss

Labels
committed Committed item enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Install SHIR via Custom Data
3 participants
@marvinbuss @sasever @amanjeetsingh