Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Firewall Rule Definitions and DNS Setup #178

Merged
merged 3 commits into from
Sep 26, 2021
Merged

Improve Firewall Rule Definitions and DNS Setup #178

merged 3 commits into from
Sep 26, 2021

Conversation

marvinbuss
Copy link
Collaborator

This PR fixes

  • Improve Portal experience so that users can select custom DNS Forwarder even though they have selected Azure Firewall as their Firewall. Not all customers use the DNS forwarder feature of Azure Firewall, which is why we need this enhancement.
  • Update of Firewall network rules and relying on IPs instead of FQDNs for compatibility reasons. I added comments to the code to make this clear for users.

@marvinbuss marvinbuss added the enhancement New feature or request label Sep 24, 2021
@marvinbuss marvinbuss self-assigned this Sep 24, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner September 24, 2021 09:47
@marvinbuss marvinbuss linked an issue Sep 24, 2021 that may be closed by this pull request
Suggestion: Add warning when deploying rules to existing Azure Firewall Policy #177
Closed
@marvinbuss marvinbuss mentioned this pull request Sep 24, 2021
Closed
andrehass
andrehass approved these changes Sep 24, 2021
View reviewed changes
Copy link

@andrehass andrehass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

marvinbuss
marvinbuss commented Sep 24, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss merged commit 3485750 into main Sep 26, 2021
@marvinbuss marvinbuss deleted the marvinbuss/dns_proxy branch September 26, 2021 14:25
@marvinbuss marvinbuss restored the marvinbuss/dns_proxy branch September 30, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrehass andrehass andrehass approved these changes

@esbran esbran Awaiting requested review from esbran

@rocavalc rocavalc Awaiting requested review from rocavalc

@sasever sasever Awaiting requested review from sasever

Assignees

@marvinbuss marvinbuss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Add warning when deploying rules to existing Azure Firewall Policy
2 participants
@marvinbuss @andrehass