Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Additional Purview Outputs #196

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

marvinbuss
Copy link
Collaborator

This PR fixes
This PR will add additional outputs for teh central Purview instance, including the resource ID of the managed storage account as well as the managed event hub. This will be required for further enhancements and integration of Purview into the Data Landing Zones as well as Data Products.

@marvinbuss marvinbuss added the enhancement New feature or request label Oct 15, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Oct 15, 2021
@marvinbuss marvinbuss self-assigned this Oct 15, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner October 15, 2021 13:40
@marvinbuss marvinbuss added the committed Committed item label Oct 15, 2021
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss removed this from the v1.2.0 milestone Oct 15, 2021
@amanjeetsingh
Copy link
Contributor

@marvinbuss - changes look fine to me; no issues there. Can you pls provide a bit of context on why/when these new outputs will be referenced and the outcome they drive? Thanks.

@marvinbuss marvinbuss added this to the v1.2.0 milestone Oct 18, 2021
@marvinbuss marvinbuss linked an issue Oct 18, 2021 that may be closed by this pull request
@marvinbuss
Copy link
Collaborator Author

marvinbuss commented Oct 18, 2021

@marvinbuss - changes look fine to me; no issues there. Can you pls provide a bit of context on why/when these new outputs will be referenced and the outcome they drive? Thanks.

Sorry for not being clear in this PR. I also forgot to link the Issue in the repo: #197

I have decided for adding additional outputs, because another solutions requires adding additional role assignments for the Landing Zone or Data Product SP. Therefore I have decided to move forward by adding additional inputs and outputs. You can also reference the existing Purview account in Bicep or ARM, but that requires that the SP has read access to the Purview account.

In summary, this will enable an automated setup of managed PE in the data factories in the all-in-one deployment: Azure/data-landing-zone#190

@amanjeetsingh Let us please first get the PR in the Landing Zone and Data products in and then merge this one. Would that work for you?

Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the background, @marvinbuss .

Approving these changes.

@marvinbuss marvinbuss merged commit 18215e9 into main Oct 19, 2021
@marvinbuss marvinbuss deleted the marvinbuss/added_outputs branch October 19, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committed Committed item enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Outputs for Purview Managed Resources
2 participants