-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Additional Purview Outputs #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@marvinbuss - changes look fine to me; no issues there. Can you pls provide a bit of context on why/when these new outputs will be referenced and the outcome they drive? Thanks. |
Sorry for not being clear in this PR. I also forgot to link the Issue in the repo: #197 I have decided for adding additional outputs, because another solutions requires adding additional role assignments for the Landing Zone or Data Product SP. Therefore I have decided to move forward by adding additional inputs and outputs. You can also reference the existing Purview account in Bicep or ARM, but that requires that the SP has read access to the Purview account. In summary, this will enable an automated setup of managed PE in the data factories in the all-in-one deployment: Azure/data-landing-zone#190 @amanjeetsingh Let us please first get the PR in the Landing Zone and Data products in and then merge this one. Would that work for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the background, @marvinbuss .
Approving these changes.
This PR fixes
This PR will add additional outputs for teh central Purview instance, including the resource ID of the managed storage account as well as the managed event hub. This will be required for further enhancements and integration of Purview into the Data Landing Zones as well as Data Products.