Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Option to select Cognitive Service Kind & Disable Azure Search #85

Merged
merged 12 commits into from
Sep 24, 2021
Merged

Added Option to select Cognitive Service Kind & Disable Azure Search #85

merged 12 commits into from
Sep 24, 2021

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Sep 16, 2021 •
edited
Loading

This PR fixes

  • This PR will add the option for users to select a specific Cognitive Service Kind for the deployment. Before, we deployed a default kind. Now there is the option in the Portal and in Bicep to select the Kind for this deployment.
  • Updated API version of app insights.
  • Linting
  • Here is a screenshot of the Portal experience:
    image

@marvinbuss marvinbuss added the enhancement New feature or request label Sep 16, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner September 16, 2021 14:54
@marvinbuss marvinbuss self-assigned this Sep 16, 2021
marvinbuss
marvinbuss commented Sep 16, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marvinbuss
marvinbuss commented Sep 16, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
* Enable multiple cognitive service deployments
1567e95 
* Allow disabling Search
* Update Portal UI
@marvinbuss marvinbuss changed the title Added Option to select Cognitive Service Kind Added Option to select Cognitive Service Kind & Disable Azure Search Sep 17, 2021
marvinbuss
marvinbuss commented Sep 17, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss linked an issue Sep 17, 2021 that may be closed by this pull request
Feature Request: Select Multiple Azure Cognitive Services #87
Closed
@marvinbuss marvinbuss added the do not merge Do not merge pull request label Sep 22, 2021
marvinbuss
marvinbuss commented Sep 24, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
Copy link
Collaborator Author

Proof that this works:
image
image

marvinbuss
marvinbuss commented Sep 24, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

andrehass
andrehass previously approved these changes Sep 24, 2021
View reviewed changes
Copy link

@andrehass andrehass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

marvinbuss
marvinbuss commented Sep 24, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

andrehass
andrehass previously approved these changes Sep 24, 2021
View reviewed changes
Copy link

@andrehass andrehass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

marvinbuss
marvinbuss commented Sep 24, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

esbran
esbran approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@esbran esbran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marvinbuss marvinbuss merged commit fb9830e into main Sep 24, 2021
@marvinbuss marvinbuss deleted the marvinbuss/cognitive_service_kind branch September 24, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esbran esbran esbran approved these changes

@andrehass andrehass andrehass left review comments

@amanjeetsingh amanjeetsingh Awaiting requested review from amanjeetsingh

@sasever sasever Awaiting requested review from sasever

Assignees

@marvinbuss marvinbuss

Labels
do not merge Do not merge pull request enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Select Multiple Azure Cognitive Services
3 participants
@marvinbuss @esbran @andrehass