Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Service Endpoint Guidance in Docs & Portal #90

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Add Service Endpoint Guidance in Docs & Portal #90

merged 3 commits into from
Sep 22, 2021

Conversation

marvinbuss
Copy link
Collaborator

This PR fixes
Add Service Endpoint Guidance in Docs and Portal for Azure Machine Learning. Azure Machine Learning has specific networking requirements today and hence we need to provide additional guidance for users, who want to use this template.

@marvinbuss marvinbuss added the enhancement New feature or request label Sep 20, 2021
@marvinbuss marvinbuss self-assigned this Sep 20, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner September 20, 2021 18:13
marvinbuss
marvinbuss commented Sep 22, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sasever
sasever requested changes Sep 22, 2021
View reviewed changes
Copy link

@sasever sasever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 81 would be better and more formal if 'therefore this configuration must be done manually'
instead 'hence this must be setup manually'

@marvinbuss
Copy link
Collaborator Author

Thanks @sasever. I Also included another link which explains how this is configured.

@marvinbuss marvinbuss requested a review from sasever September 22, 2021 07:54
@marvinbuss marvinbuss linked an issue Sep 22, 2021 that may be closed by this pull request
Feature Request: Add Information about Service Endpoint Requirements #89
Closed
sasever
sasever approved these changes Sep 22, 2021
View reviewed changes
Copy link

@sasever sasever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, Much better with the link.

@marvinbuss
Copy link
Collaborator Author

Good to go, Much better with the link.

Thanks for the quick response. 🥇

@marvinbuss marvinbuss merged commit 311c857 into main Sep 22, 2021
@marvinbuss marvinbuss deleted the marvinbuss/service_endpoint_guidance branch September 22, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasever sasever sasever approved these changes

@amanjeetsingh amanjeetsingh Awaiting requested review from amanjeetsingh

@esbran esbran Awaiting requested review from esbran

@andrehass andrehass Awaiting requested review from andrehass

Assignees

@marvinbuss marvinbuss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Information about Service Endpoint Requirements
2 participants
@marvinbuss @sasever