Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Feature: Bulk Task Support #318

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feature: Bulk Task Support #318

wants to merge 6 commits into from

Conversation

brnleehng
Copy link
Collaborator

@brnleehng brnleehng requested review from bgklein and zfengms October 11, 2018 18:13
Copy link

@bgklein bgklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if R plays nice with concurrency? With the python SDK we had the benefit of the GIL which simplified a lot of concurrency stuff


staticHtml <- "<h1>Errors:</h1>"
for (i in 1:length(failTasks)) {
if (failTasks[i] == 1) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be an else somewhere?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or closue earlier


if (!is.null(cloudCombine)) {
assign("cloudCombine", cloudCombine, .doAzureBatchGlobals)
containerSettings$imageName <- "brianlovedocker/doazureparallel-merge-dockerfile:0.12.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've heard some of the pro's to having this be here, but the docker image should likely be moved to a more official sounding host, if if not hosted in the official Microsoft Docker / ACR

threads = 1
){
size <- length(tasks)
self$originalTaskCollection <- tasks
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make the extra reference/clone.

@Azure Azure deleted a comment from lintr-bot Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants