Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Fix: Option to set maximum expiry date for task completion upload tokens #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zerweck
Copy link

@zerweck zerweck commented Aug 6, 2019

Proposed fix for #363

@msftclas
Copy link

msftclas commented Aug 6, 2019

CLA assistant check
All CLA requirements met.

@zerweck
Copy link
Author

zerweck commented Aug 6, 2019

No Idea why Travis failed :/

@zerweck
Copy link
Author

zerweck commented Aug 7, 2019

Looking at the build log, it doesn't seem like a problem related to my diff.
Is it possible to just re-run the build?

@brnleehng
Copy link
Collaborator

Hey @zerweck

Thanks for the PR! Appreciate it -- can you also update the docs so other users can use it (https://github.com/Azure/doAzureParallel/blob/master/docs/52-azure-foreach-options.md)? I'll take a look into why the build is failing. I'm also taking a look at some other better namings of the parameter.

I'm leaning towards fileSasExpiryTime or containerSasExpiryTime instead of a maxDate.

Thanks,
Brian

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants