Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry-run for update command #197

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Dry-run for update command #197

merged 4 commits into from
Mar 22, 2023

Conversation

bosesuneha
Copy link
Member

Description

Implemented dry-run flag for update command

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Integration Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bosesuneha bosesuneha changed the title added dry-run Dry-run for update command Mar 21, 2023
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bosesuneha bosesuneha force-pushed the sunehabose/dryrun-for-update branch 2 times, most recently from c1dd171 to da6a888 Compare March 22, 2023 02:24
@bosesuneha bosesuneha force-pushed the sunehabose/dryrun-for-update branch from da6a888 to 8cec62f Compare March 22, 2023 02:29
@bosesuneha bosesuneha merged commit fe79cf1 into main Mar 22, 2023
@bosesuneha bosesuneha deleted the sunehabose/dryrun-for-update branch March 22, 2023 15:43
aamgayle pushed a commit to aamgayle/draft that referenced this pull request Mar 23, 2023
bosesuneha added a commit that referenced this pull request Mar 24, 2023
davidgamero pushed a commit to davidgamero/draft that referenced this pull request Mar 29, 2023
@davidgamero davidgamero mentioned this pull request Apr 10, 2023
aamgayle pushed a commit that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants